Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Fix test executions after internal changes #3063

Merged
merged 2 commits into from
Apr 3, 2023
Merged

(maint) Fix test executions after internal changes #3063

merged 2 commits into from
Apr 3, 2023

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Mar 10, 2023 •
edited
Loading

Description Of Changes

This merge request updates the tests we have for open source
Chocolatey CLI after the changes we expect to need to be
made in our internal structure to make sure they still
are able to pass.

Motivation and Context

We have a need to change our internal structure, as such we need to make minor changes to the tests as well to make sure they are still valid and have not been broken.

Testing

  1. Run through test kitchen

Operating Systems Testing

  • Windows Server 2019

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

@AdmiringWorm AdmiringWorm self-assigned this Mar 10, 2023
@AdmiringWorm
(maint) Fix test executions after internal changes
f2718e5 
This commit updates the tests we have for open source
Chocolatey CLI after the changes we expect to need to be
made in our internal structure to make sure they still
are able to pass.
@AdmiringWorm
(maint) Fix test executions after internal changes
7e59a52 
This commit updates the tests we have for open source
Chocolatey CLI after the changes we expect to need to be
made in our internal structure to make sure they still
are able to pass.
@AdmiringWorm AdmiringWorm marked this pull request as ready for review March 31, 2023 14:18
@AdmiringWorm AdmiringWorm requested a review from vexx32 March 31, 2023 14:18
vexx32
vexx32 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for sorting this out! 💖

@vexx32 vexx32 merged commit 370e366 into chocolatey:develop Apr 3, 2023
@AdmiringWorm AdmiringWorm deleted the new-internal-setup branch April 3, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

Assignees

@AdmiringWorm AdmiringWorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdmiringWorm @vexx32